Some minor bugs

Question

Hi,

I've found a few minor issues with Integral FTP. I have fixes for two:

* FTPClient_onTransferProgress removes tags from ftpClient._tags via _getTag, so a null tag is passed on subsequent calls to onTransferProgress and onUploadFile/onDownloadFile.
* FTPClient_onDirectoryList passes file.name instead of file.path to fileList.add, so the file name and path have the same value.

You can download the patch from http://www.alittletooquiet.net/media/integralftp/ftpclient-fixes.diff.

The last issue I'm seeing is in the JAR itself, so I can't track it down completely. It seems that after the first file transfer, calls to onTransferProgress continue to be passed the taskID and path from the first transfer. I have a simple example that demonstrates the problem:

http://www.alittletooquiet.net/media/integralftp/integral_ftp_test.zip

To run the test, extract the zip file, copy in the IntegralFTP.jar and ftpclient.js files, edit test.html to fill in the right server information, and open the file in a web browser.

The output I get is as follows:

Initializing...
Initialized.
Connecting.
Connected.
Uploading 1.dat.
Transfer progress: taskID = 2, path = /1.dat.
Uploaded 1.dat.
Uploading 2.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 2.dat.
Uploading 3.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 3.dat.
Uploading 4.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 4.dat.
Uploading 5.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 5.dat.
Uploading 6.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 6.dat.
Uploading 7.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 7.dat.
Uploading 8.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 8.dat.
Uploading 9.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 9.dat.
Uploading 10.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 10.dat.
No more files.

Is there any way to fix this? Tracking transfer progress correctly with multiple uploads is impossible without a fix.

Thanks,
Forest

Answer 1

Hi Hans,

No need to apologize. You have been very helpful and forthcoming, and I appreciate that.

I look forward to testing a fix.

Thanks,
Forest

Answer 2

Hi Forest

We've put up a patch. You can download it from the same URL that I e-mailed you on March 16. I hope this finally fixes the problem.

- Hans (EnterpriseDT)

Answer 3

Hi Hans,

Thanks, I will test first thing in the morning.

-Forest

Answer 4

Hi Hans,

I downloaded the files but they seem to be the same as the last time I retrieved them (April 2nd). Maybe the filename is different?

In the meantime, I decided to implement a server-side keep alive option. It was easy to do and it does seem to fix the issue, which confirms your diagnosis. Supporting keep-alive on the server side will be helpful with other clients, anyway, particularly over NATed connections.

I can still test your fix with server-side keep-alive disabled, if you would like.

Thanks,
Forest