Some minor bugs

Question

Hi,

I've found a few minor issues with Integral FTP. I have fixes for two:

* FTPClient_onTransferProgress removes tags from ftpClient._tags via _getTag, so a null tag is passed on subsequent calls to onTransferProgress and onUploadFile/onDownloadFile.
* FTPClient_onDirectoryList passes file.name instead of file.path to fileList.add, so the file name and path have the same value.

You can download the patch from http://www.alittletooquiet.net/media/integralftp/ftpclient-fixes.diff.

The last issue I'm seeing is in the JAR itself, so I can't track it down completely. It seems that after the first file transfer, calls to onTransferProgress continue to be passed the taskID and path from the first transfer. I have a simple example that demonstrates the problem:

http://www.alittletooquiet.net/media/integralftp/integral_ftp_test.zip

To run the test, extract the zip file, copy in the IntegralFTP.jar and ftpclient.js files, edit test.html to fill in the right server information, and open the file in a web browser.

The output I get is as follows:

Initializing...
Initialized.
Connecting.
Connected.
Uploading 1.dat.
Transfer progress: taskID = 2, path = /1.dat.
Uploaded 1.dat.
Uploading 2.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 2.dat.
Uploading 3.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 3.dat.
Uploading 4.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 4.dat.
Uploading 5.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 5.dat.
Uploading 6.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 6.dat.
Uploading 7.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 7.dat.
Uploading 8.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 8.dat.
Uploading 9.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 9.dat.
Uploading 10.dat.
Transfer progress: taskID = 2, path = 1.dat.
Uploaded 10.dat.
No more files.

Is there any way to fix this? Tracking transfer progress correctly with multiple uploads is impossible without a fix.

Thanks,
Forest

Answer 1

Hi,

I'll be looking to deploy my IntegralFTP-based application soon. The first release does not rely on getting these bugs fixed, but if you can provide some idea of how likely it is that these issues are addressed, I'd appreciate it.

I'll be purchasing a license soon.

Thanks,
Forest

Answer 2

Thanks a heap for the fixes! I wish we had more users like you. Actually most of our users are great, but getting fixes sent in a diff is just brilliant.

I've applied them already and they will definitely be in the 4.0.1 release which is due out in the next few days.

I think the bug in the jar has already been fixed in this upcoming version. If you e-mail us (support@...) then I'll send you a link to a prerelease distribution of 4.0.1.

- Hans (EnterpriseDT)

Answer 3

Hi Hans,

Thanks for taking a look at this. I will send an e-mail shortly so I can test the prerelease version.

There is one more issue I noticed. In the testing I've done, the remoteDirectory argument to onDirectoryList is always "/". It's easy to work around, but I thought you would want to know about the problem.

Thanks,
Forest

Answer 4

Hi Hans,

I tested the pre-release version. Thanks for applying the fixes I posted.

Unfortunately, the onTransferProgress bug demonstrated by my example is still present.

I am going to buy a license because the features that I need at the moment work fine. I will need to add transfer progress tracking in the future, though.

Thanks,
Forest

Answer 5

Hi Hans,

With the pre-release version I am testing, I see a lot of dropped connections. The client is disconnected consistently after about 30 seconds of being idle. onDisconnect is called with reason code 2 (lost connection).

I didn't see this with the trial version I was testing with, and I haven't changed servers. Any idea what the cause might be?

Thanks,
Forest

Answer 6

Can you please e-mail or post the log from the Java console showing the failure?

- Hans (EnterpriseDT)

Answer 7

Looks like it's too long to fit in a forum post. I'll upload it somewhere else.

Answer 8

You could just zip it up and e-mail it to support@...

- Hans (EnterpriseDT)

Answer 9

http://www.alittletooquiet.net/media/in ... /error.log

Answer 10

Any chance you could post the server logs as well?

- Hans (EnterpriseDT)